Different Cloak SFX For Different Ships

[SGM82]

Hey all,

               I just curious as to wheather its possible to assign different cloak SFX to different ships.

Your thought on this please

[MLeo]

Unfortunately, not that easily.
It would involve making the normal cloaking sound not play, and then, for each ship assign a "default" cloaking sound, unless overridden.
And then you need to make it play said sound.

It's doable I suppose.

[JimmyB76]

sucks it doesnt work as easily as BP sfx can lol

[Rob Archer]

I'll have a go... see what i can come up with

[MLeo]

sucks it doesnt work as easily as BP sfx can lol

No, that would have been nice, except that unlike a bridge, there are more ships.


I suppose a ShipPluginSounds would be doable. Might as well create one. ;)

[Rob Archer]

I suppose a ShipPluginSounds would be doable. Might as well create one. ;)

Would you mind if i had a go creating a cloak sounds mod MLEO

i think it could be easy although im prepared to admit i might be wrong

[MLeo]

Go ahead (no problem at all, it would be pretty evil of me to deny you that).

TMP Warmup was infact intended to be replaced by an FTech for Textures (also replacement for SDT). To be more accurate, TMP Warmup sparked the idea anyway.

A couple of pointers, look in StaticDefs.py, but do not alter it (you can manipulate the sounds)! Don't create a TGSound for each time you need to play it (BC will hate you for it after a couple of times, and it can make BC hang for a moment each time. Also, caching is your friend, you only need 1 TGSound per sound.

[Rob Archer]

Go ahead (no problem at all, it would be pretty evil of me to deny you that).

Thanks for the tips Mleo i already got a romulan warbird to Play the Atlantis Gate Roll when it cloaks and the Canadian National Anthem When it Decloaks... 

its not quite cannon but its funny as hell..

[MLeo]

It sure is (how did you think I tested BPSounds ).

Canon would be that every ship has the same sound (atleast I never heard a different sound).

[Dawg81]

Go ahead (no problem at all, it would be pretty evil of me to deny you that).

Thanks for the tips Mleo i already got a romulan warbird to Play the Atlantis Gate Roll when it cloaks and the Canadian National Anthem When it Decloaks... 

its not quite cannon but its funny as hell..

ROFL i know a few canucks that would get a laugh out of that rofl cookie for ur efforts

[KrrKs]

As far as I know USS Apollo's QuickBattleAddon (or whatever it was named) included a differend Cloaksoand for Ships with a PhaseCloak.

[MLeo]

In case of ATP (and in FTech) the phase cloak sound is played after the normal cloaking sound.

[Rob Archer]

Edit: Done

http://bc-central.net/forums/index.php/topic,5055.0.html

Mod is available on Filefront But NOT BCFiles

[MLeo]

I hate to say it, but I think it contains an error.
In both DefaultCloak and DefaultDecloak you reference a pSound, a variable which does not exist in any accessable scope, I suspect it will give a nice NameError when you try it.

I'm also not entirely convinced that "App.g_kSoundManager.StopAllSounds()" is the right thing to do either.

I also don't think you are stopping the currently playing sound. You do call "App.g_kSoundManager.StopSound(sCloakSFX)" this, but this is the new cloaking sound, not the stock one.

It also won't work in, for example, cutscenes in a different set than the player set, but I suspect this case won't happen that often.


I'm terribly sorry to be so negative about this.

[Rob Archer]

No Need to worry about being Negetive
I should say thanks for pointing that out MLEO looks like i uploaded the wrong Archive by mistake  :oops: Fixed it now

[MLeo]

It still contains an error, in the DefaultCloak you put the following:

Code: [Select]

if pDeCloakSound:
pCloakSound.Play()And in DefaultDecloak:

Code: [Select]

if pDeCloakSound:
pDeCloakSound.Play()It does suggest that the first one is wrong.


You are also still not stopping the default cloak/uncloak sounds.

And there is something else, slightly odd, in the (De)Cloak event handler you pass strings to StopSound, and in Default(De)Cloak you pass TGSound objects to StopSound.

[Rob Archer]

yeah thanks again MLEO i just noticed that problem...

Good Job your here 

It should be fixed Now i hope

[MLeo]

Include the following lines in the autoload file and I'll be happy, for now (that is, until some more structural solution is created).

Code: [Select]

import App
for sound in ["cloak", "uncloak"]:
  pSound = App.g_kSoundManager.GetSound(sound)
  if pSound:
    pSound.SetVolume(0)
This will ensure that the actual sounds won't be played (they will, but not audiable).

[Rob Archer]

Include the following lines in the autoload file and I'll be happy, for now (that is, until some more structural solution is created).

Code: [Select]

import App
for sound in ["cloak", "uncloak"]:
  pSound = App.g_kSoundManager.GetSound(sound)
  if pSound:
    pSound.SetVolume(0)
This will ensure that the actual sounds won't be played (they will, but not audiable).

MLeo wouldnt it be just as easy to replace the old sound files with blank ones and include a backup... with the mod?

[MLeo]

I don't like to overwrite things, for example, someone might already have replaced the cloak sound with a mod, now if you include the stock ones as backup, then the earlier mod gets lost. It's one of the reasons why I promoted Uniform mutators, and will promote BPUniforms, since they (shouldn't) override.

And something else, your mod could load the stock cloak sound under a different name (say stock_cloak and stock_decloak) and use those for the Default(De)Cloak sounds.